Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitignore to reflect new auto visual tests #10430

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Update .gitignore to reflect new auto visual tests #10430

merged 4 commits into from
Jul 14, 2023

Conversation

enavarro51
Copy link
Contributor

Summary

Update the .gitignore to skip unneeded visual test files.

Details and comments

With the changes in #9961, the entries in .gitignore needed to be updated to reflect the new directory structure.

@enavarro51 enavarro51 requested a review from a team as a code owner July 13, 2023 21:42
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

jakelishman
jakelishman approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edwin - I idly thought about this when looking at the PR, then totally forgot to do anything about it.

@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jul 13, 2023
@coveralls
Copy link

coveralls commented Jul 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5549121859

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.006%) to 85.998%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
crates/qasm2/src/lex.rs 1 91.14%
crates/qasm2/src/parse.rs 6 96.65%
Totals Coverage Status
Change from base Build 5548967359: -0.006%
Covered Lines: 71825
Relevant Lines: 83519
💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Jul 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2023
@mtreinish mtreinish enabled auto-merge July 14, 2023 16:37
@mtreinish mtreinish added this pull request to the merge queue Jul 14, 2023
Merged via the queue into Qiskit:main with commit 8e83521 Jul 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enavarro51 @qiskit-bot @coveralls @jakelishman @mtreinish