raise an exception with a custom gate with clbits or no qubits #10438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before adding tests and reno, @jakelishman do you think adding this limitation makes sense? |
Pull Request Test Coverage Report for Build 5643565062
💛 - Coveralls |
jakelishman
reviewed
Jul 17, 2023
qiskit/circuit/quantumcircuit.py
Outdated
Comment on lines
5093
to
5099
| # Gate definitions with 0 qubits or with any classical bits are not allowed. | ||
| if operation.num_qubits == 0 or operation.num_clbits != 0: | ||
| raise CircuitError( | ||
| "OpenQASM 2 does not allow gate definitions with no qubits or with any " | ||
| f"classical bit: '{operation.name}' has {operation.num_qubits} qubits " | ||
| f"and {operation.num_clbits} clbits" | ||
| ) |
There was a problem hiding this comment.
The error should be QASM2ExportError, but otherwise this is fine.
Not sure the comment is needed, since the error message says the exact same thing ;)
There was a problem hiding this comment.
Good catch. Thanks! done in fc0d3be
|
One or more of the the following people are requested to review this:
|
1ucian0
added
the
Changelog: Bugfix
jakelishman
approved these changes
Jul 24, 2023
jakelishman
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
* raise an exception with a custom gate with no qubits or with one-or-more clbits * QASM2ExportError * test_circuit_raises_invalid_custom_gate_1 * test_circuit_raises_invalid_custom_gate_2 * reno * Split error messages to be more specific * Fix testing bug * Fixup release note --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com> (cherry picked from commit 208c29a)
|
thank you @1ucian0 @jakelishman |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
… (#10485) * raise an exception with a custom gate with no qubits or with one-or-more clbits * QASM2ExportError * test_circuit_raises_invalid_custom_gate_1 * test_circuit_raises_invalid_custom_gate_2 * reno * Split error messages to be more specific * Fix testing bug * Fixup release note --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com> (cherry picked from commit 208c29a) Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
to24toro
pushed a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
…t#10438) * raise an exception with a custom gate with no qubits or with one-or-more clbits * QASM2ExportError * test_circuit_raises_invalid_custom_gate_1 * test_circuit_raises_invalid_custom_gate_2 * reno * Split error messages to be more specific * Fix testing bug * Fixup release note --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10435
Fix #7351
Currently, OpenQASM 2 exporter dumps invalid code when a custom gate has no qubits or has classical wires involved.
The no-qubit case it is considered invalid by the OpenQASM 2 grammar:
I think the case of
<id>referring to classical wires can be inferred from the name of the statement:gate, as in a quantum gate.