Fix UnassignedDurationError of update_from_instruction_schedule_map #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
nkanazawa1989
added
the
Changelog: Bugfix
|
Thanks @to24toro could you please add a test to https://github.com/Qiskit/qiskit-terra/blob/a804df58c8e59c101fc3c13ef6a1a4cb172b9a5b/test/python/transpiler/test_target.py#L1144 and write a release note with bugfix? |
releasenotes/notes/fix-update-from-instruction-schedule-map-d1cba4e4db4b679e.yaml
Outdated
Show resolved
Hide resolved
…cba4e4db4b679e.yaml
Pull Request Test Coverage Report for Build 5597068363
💛 - Coveralls |
nkanazawa1989
approved these changes
Jul 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
to24toro
added a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
…iskit#10447) * fix UnassignedDurationError of update_from_instruction_schedule_map * add test * add reno * rename test * fix reno * Update releasenotes/notes/fix-update-from-instruction-schedule-map-d1cba4e4db4b679e.yaml --------- Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update_from_instruction_schedule_map failed when the duration of schedules is treated as a parameter.
I added try.. except statement and set duration
Nonewhen the duration is the parameter.Details and comments