Fix empty-barrier handling in OpenQASM 2 #10469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
The new parser would allow a `barrier;` statement, implicitly broadcasting it across all qubits in scope. This is technically not supported by the OpenQASM 2 specification, but is a useful quality-of-life extension to the specification (in the same way that Qiskit interprets barriers, and the OpenQASM 3 specification defines the `barrier;` statement). The precise rule is added to the new parser's `strict` mode. The OpenQASM 2 _exporter_ similarly should not have been putting out `barrier;` statements. These could only occur in Qiskit when a barrier was explicitly constructed with zero elements (as opposed to the call `QuantumCircuit.barrier()`, which has the all-in-scope behaviour), and consequently have no actual meaning or effect. The exporter is modified to simply skip such instructions, for as long as Qiskit permits the qubitless barrier statement.
jakelishman
force-pushed
the
qasm2/fix-zero-op-barrier
branch
from
65b868a
to
2979c73
Compare
Pull Request Test Coverage Report for Build 5625787521
💛 - Coveralls |
mtreinish
added
the
Rust
mtreinish
approved these changes
Jul 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
The new parser would allow a `barrier;` statement, implicitly broadcasting it across all qubits in scope. This is technically not supported by the OpenQASM 2 specification, but is a useful quality-of-life extension to the specification (in the same way that Qiskit interprets barriers, and the OpenQASM 3 specification defines the `barrier;` statement). The precise rule is added to the new parser's `strict` mode. The OpenQASM 2 _exporter_ similarly should not have been putting out `barrier;` statements. These could only occur in Qiskit when a barrier was explicitly constructed with zero elements (as opposed to the call `QuantumCircuit.barrier()`, which has the all-in-scope behaviour), and consequently have no actual meaning or effect. The exporter is modified to simply skip such instructions, for as long as Qiskit permits the qubitless barrier statement. (cherry picked from commit e75893d)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
The new parser would allow a `barrier;` statement, implicitly broadcasting it across all qubits in scope. This is technically not supported by the OpenQASM 2 specification, but is a useful quality-of-life extension to the specification (in the same way that Qiskit interprets barriers, and the OpenQASM 3 specification defines the `barrier;` statement). The precise rule is added to the new parser's `strict` mode. The OpenQASM 2 _exporter_ similarly should not have been putting out `barrier;` statements. These could only occur in Qiskit when a barrier was explicitly constructed with zero elements (as opposed to the call `QuantumCircuit.barrier()`, which has the all-in-scope behaviour), and consequently have no actual meaning or effect. The exporter is modified to simply skip such instructions, for as long as Qiskit permits the qubitless barrier statement. (cherry picked from commit e75893d) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
to24toro
pushed a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
The new parser would allow a `barrier;` statement, implicitly broadcasting it across all qubits in scope. This is technically not supported by the OpenQASM 2 specification, but is a useful quality-of-life extension to the specification (in the same way that Qiskit interprets barriers, and the OpenQASM 3 specification defines the `barrier;` statement). The precise rule is added to the new parser's `strict` mode. The OpenQASM 2 _exporter_ similarly should not have been putting out `barrier;` statements. These could only occur in Qiskit when a barrier was explicitly constructed with zero elements (as opposed to the call `QuantumCircuit.barrier()`, which has the all-in-scope behaviour), and consequently have no actual meaning or effect. The exporter is modified to simply skip such instructions, for as long as Qiskit permits the qubitless barrier statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new parser would allow a
barrier;statement, implicitly broadcasting it across all qubits in scope. This is technically not supported by the OpenQASM 2 specification, but is a useful quality-of-life extension to the specification (in the same way that Qiskit interprets barriers, and the OpenQASM 3 specification defines thebarrier;statement). The precise rule is added to the new parser'sstrictmode.The OpenQASM 2 exporter similarly should not have been putting out
barrier;statements. These could only occur in Qiskit when a barrier was explicitly constructed with zero elements (as opposed to the callQuantumCircuit.barrier(), which has the all-in-scope behaviour), and consequently have no actual meaning or effect. The exporter is modified to simply skip such instructions, for as long as Qiskit permits the qubitless barrier statement.Details and comments
Fix #10465.