Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Pass manager refactoring: add passmanager module (#10124)"" #10474

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Revert "Revert "Pass manager refactoring: add passmanager module (#10124)"" #10474

merged 1 commit into from
Jul 22, 2023

Conversation

mtreinish
Copy link
Member

Now that 0.45 development is open on main we can restore #10124. This reverts #10454

@mtreinish mtreinish requested a review from a team as a code owner July 21, 2023 20:49
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

@mtreinish mtreinish added this to the 0.45.0 milestone Jul 21, 2023
jakelishman
jakelishman approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@jakelishman jakelishman added Changelog: New Feature Include in the "Added" section of the changelog Changelog: API Change Include in the "Changed" section of the changelog labels Jul 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5626486699

  • 389 of 413 (94.19%) changed or added relevant lines in 13 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 85.936%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/passmanager/base_pass.py 40 41 97.56%
qiskit/transpiler/runningpassmanager.py 55 57 96.49%
qiskit/passmanager/passmanager.py 89 95 93.68%
qiskit/passmanager/passrunner.py 76 83 91.57%
qiskit/passmanager/flow_controllers.py 63 71 88.73%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.9%
Totals Coverage Status
Change from base Build 5626235878: 0.03%
Covered Lines: 73026
Relevant Lines: 84977
💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Jul 22, 2023
Merged via the queue into main with commit 2710765 Jul 22, 2023
15 checks passed
@Eric-Arellano Eric-Arellano deleted the revert-10454-revert-pass-manager-module branch July 22, 2023 14:07
to24toro pushed a commit to to24toro/qiskit-terra that referenced this pull request Aug 3, 2023
@mtreinish @to24toro
Revert "Revert "Pass manager refactoring: add passmanager module (Qis…
288e705 
…kit#10124)" (Qiskit#10454)" (Qiskit#10474)

This reverts commit c03e4c7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees

@nkanazawa1989 nkanazawa1989

Labels
Changelog: API Change Include in the "Changed" section of the changelog Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mtreinish @qiskit-bot @coveralls @jakelishman @nkanazawa1989