-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pulse channel index validation #10476
Conversation
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5644058125
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this has been around for a while now, so could you add a test and potentially a one-liner bug-fix release note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks!
btw, if you want your PR to autoclose an issue on merge, there's specific words you have to use, with one issue per line. "Addresses" isn't one unfortunately, so I updated your top comment to "Fix", which is one of them. |
Thanks @jakelishman! |
* Correct channel index validation * Add tests and release note. (cherry picked from commit 802a735)
* Correct channel index validation * Add tests and release note.
Summary
Fix a bug in the validation of Pulse channel index.
Fix #10475