Add tests of Expr support through SabreSwap
#10511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a small bug with the general control-flow handling, where a `SwitchCaseOp` would not have its classical wires respected, which left it possible to be routed out-of-order.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5673409609
💛 - Coveralls |
mtreinish
approved these changes
Jul 27, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
This also fixes a small bug with the general control-flow handling, where a `SwitchCaseOp` would not have its classical wires respected, which left it possible to be routed out-of-order. (cherry picked from commit 1a87703)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
This also fixes a small bug with the general control-flow handling, where a `SwitchCaseOp` would not have its classical wires respected, which left it possible to be routed out-of-order. (cherry picked from commit 1a87703) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
to24toro
pushed a commit
to to24toro/qiskit-terra
that referenced
this pull request
Aug 3, 2023
This also fixes a small bug with the general control-flow handling, where a `SwitchCaseOp` would not have its classical wires respected, which left it possible to be routed out-of-order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This also fixes a small bug with the general control-flow handling, where a
SwitchCaseOpwould not have its classical wires respected, which left it possible to be routed out-of-order.Details and comments
Fix #10232. Feature changelog via #10331. No changelog for the bugfix because it was unreleased as yet.