Schedule with backend v2 #10564
Schedule with backend v2 #10564
Conversation
…e/target_from_cofiguration
| @@ -31,5 +30,5 @@ def __init__(self, inst_map: InstructionScheduleMap, meas_map: List[List[int]], | |||
| dt: Sample duration. | |||
| """ | |||
| self.inst_map = inst_map | |||
| self.meas_map = format_meas_map(meas_map) | |||
| self.meas_map = meas_map | |||
There was a problem hiding this comment.
removed format_meas_map .
When I make target class like this
Target(meas_map=schedule_config.meas_map)the type of meas_map is restricted to list (#10258 (comment)).
qiskit/scheduler/lowering.py
Outdated
| def convert_to_target(func): | ||
| """ | ||
| A wrapper function that prepares target instead of scheduleConfig | ||
| when the ScheduleConfing is specified. | ||
|
|
||
| If the ScheduleConfig is deprecated, this fucntion will be removed. | ||
| """ | ||
|
|
||
| @deprecate_arg( | ||
| "schedule_config", | ||
| deprecation_description="Using target instead of schedule_config.", | ||
| since="0.25.0", | ||
| pending=True, | ||
| predicate=lambda schedule_config: schedule_config is not None, | ||
| ) | ||
| def _wrapped(circuit: QuantumCircuit, schedule_config: ScheduleConfig, target: Target): | ||
| if schedule_config is not None: | ||
| target = Target(schedule_config.meas_map) | ||
| target.update_from_instruction_schedule_map(schedule_config.inst_map) | ||
| return func(circuit, target=target) | ||
|
|
||
| return _wrapped |
There was a problem hiding this comment.
Added a wrapper function for ScheduleConfig deprecation.(ref: #10285 (comment))
to24toro
requested review from
eggerdj,
wshanks,
a team and
jyu00
as code owners
|
One or more of the the following people are requested to review this:
|
|
Hi @to24toro, I'm also studying in area that needs schedule function and reached to this end of your work. You seem to have changed a lot in qiskit/pulse. I assume that I connected wrongly with my current qiskit well. It would be great if you leave the comment of whether current branch is working well or not. Also, if you are okay, I'd like to hear and participate in your progress. Thanks for the work. |
|
@sungwooahn |
to24toro
force-pushed
the
feature/schedule_with_backendV2
branch
from
715e090
to
c63073f
Compare
to24toro
force-pushed
the
feature/schedule_with_backendV2
branch
from
c63073f
to
609e238
Compare
to24toro
force-pushed
the
feature/schedule_with_backendV2
branch
from
c7dfb53
to
7c276e4
Compare
to24toro
force-pushed
the
feature/schedule_with_backendV2
branch
from
7c276e4
to
983d3e4
Compare
|
#10988 solve the bug of scheduling with backendV2. |
Summary
Closed #10285 and reopened at this PR.
This PR fixes the bug of scheduling with backendV2.
We aim to replace ScheduleConfig with Target when backendV1 will be deprecated in the future.
Details and comments
When making a schedule, Target and ScheduleConfig are prepared by dispatching the type of backend. Now I consider ScheduleConfig class will be deprecated at the same time the backendV1 is dropped.
When deprecating ScheduleConfig, Target will become required and ScheduleConfig will be dropped.
Added the new test for schedule with backendV2 in
test/python/pulse/test_builder_v2.py.API change
targettoscheduleinschedule.py.targettosequenceinsequence.py.targettolower_gatesinqiskit/scheduler/lowering.py.targettolas_soon_as_possibleinqiskit/scheduler/methods/basic.py.targettoas_late_as_possibleinqiskit/scheduler/methods/basic.py.targettoschedule_circuitinqiskit/scheduler/schedule_circuit.py.