Change 1q UnitaryGate definition to use U instead of U3 #10597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing U3 from unitary and moving it to the U gate
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5814691289
💛 - Coveralls |
mtreinish
reviewed
Aug 9, 2023
There was a problem hiding this comment.
Thanks for pushing this. The code itself LGTM and is probably long overdue.
The only thing that I think is missing is probably a release note so that we can document the change as part of the next qiskit release. If you could add one that just documents the definition of UnitaryGate for single qubit unitaries is now in terms of UGate instead of the legacy U3Gate class that either as an upgrade or an other section note. The process for adding a release note is documented here: https://github.com/Qiskit/qiskit-terra/blob/main/CONTRIBUTING.md#release-notes
|
should be done |
mtreinish
added
the
Changelog: API Change
mtreinish
approved these changes
Aug 10, 2023
mtreinish
changed the title
SamD-1998
pushed a commit
to SamD-1998/qiskit-terra
that referenced
this pull request
Sep 7, 2023
* Clean up to use U vs U3 Removing U3 from unitary and moving it to the U gate * fixing test * Create unitary-u-not-u3-0a32c2d968f7890e.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced U3 with U gate so that when I decompose it uses U not U3 as U is the gate going forward.
Details and comments