Handle final comments with no terminating newline in OpenQASM 2 #10773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an OpenQASM 2 program to be parsed ended in a comment with no terminating '\n', the lexer would fail to notice the end of the file and would instead attempt to emit the second '/' of the comment introduction as a 'Slash` token.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
mtreinish
previously approved these changes
Sep 5, 2023
test/python/qasm2/test_structure.py
Outdated
| def test_allows_empty(self): | ||
| self.assertEqual(qiskit.qasm2.loads(""), QuantumCircuit()) | ||
|
|
||
| @ddt.data("", "\n", "\r\n", "\n ") |
There was a problem hiding this comment.
Do you want to test "\n\t" and "\r\n\t" too? Just thinking of other whitespace combinations to make the testing here a bit more thorough.
There was a problem hiding this comment.
The only one of these cases that was actually buggy was the one with no whitespace at all, but it doesn't matter a great deal that there's additional cases.
There was a problem hiding this comment.
I assumed you were already afk, so I took the liberty of adding them. I hope you dont mind.
There was a problem hiding this comment.
That's ok, it's all our code anyway.
--------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
1ucian0
dismissed stale reviews from mtreinish and Eric-Arellano
via
c410d75
1ucian0
approved these changes
Sep 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Handle final comments with no terminating newline in OpenQASM 2 Previously, if an OpenQASM 2 program to be parsed ended in a comment with no terminating '\n', the lexer would fail to notice the end of the file and would instead attempt to emit the second '/' of the comment introduction as a 'Slash` token. * Run `cargo fmt` * Testing extra cases --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 3075f14)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
…) (#10778) * Handle final comments with no terminating newline in OpenQASM 2 Previously, if an OpenQASM 2 program to be parsed ended in a comment with no terminating '\n', the lexer would fail to notice the end of the file and would instead attempt to emit the second '/' of the comment introduction as a 'Slash` token. * Run `cargo fmt` * Testing extra cases --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> --------- Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 3075f14) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, if an OpenQASM 2 program to be parsed ended in a comment with no terminating '\n', the lexer would fail to notice the end of the file and would instead attempt to emit the second '/' of the comment introduction as a 'Slash` token.
Details and comments
Fix #10770.