Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated property num_ancilla_qubits #10793

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

danielleodigie
Copy link
Contributor

@danielleodigie danielleodigie commented Sep 7, 2023

Resolves #10743
This PR removes the code associated with the property num_ancilla_qubits in the PolynomialPauliRotations class

To-Do:

danielleodigie and others added 2 commits September 7, 2023 11:14
…ations class

removed function and deprecate_func from polynomial_pauli_rotations.py
added release note with upgrade notice
@danielleodigie danielleodigie requested a review from a team as a code owner September 7, 2023 15:18
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 7, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Sep 7, 2023
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for taking care of this. Just one small comment on the release note syntax. Also thanks for doing the terra 0.16 -> qiskit 0.23 conversion. I would have totally forgotten about that.

- |
The property ``num_ancilla_qubits`` from the class :class:`~qiskit.circuit.library.arithmetic.PolynomialPauliRotations`
has been removed, as deprecated in Qiskit 0.23.0.
Instead, use the property :attr:`~num_ancillas`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think sphinx will resolve this correctly. You probably need to give it a bit more context on the reference. Something like this:

Suggested change
Instead, use the property :attr:`~num_ancillas`.
Instead, use the property :attr:`.PolynomialPauliRotations.num_ancillas`.

should work it will also make the text read PolynomialPauliRotations.num_ancillas instead of just num_ancillas

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick updates.

@mtreinish mtreinish added this pull request to the merge queue Sep 7, 2023
Merged via the queue into Qiskit:main with commit 031c0a2 Sep 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove code deprecated in 0.16 (released on October 15, 2020)
3 participants