-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated functions in qiskit.scheduler.utils #10879
Removed deprecated functions in qiskit.scheduler.utils #10879
Conversation
One or more of the the following people are requested to review this:
|
This partially overlaps with #10779 . However, we can merge this independently, as it will allow us to remove |
format_meas_map = deprecate_function( | ||
'"format_meas_map" has been moved to "qiskit.pulse.utils"', | ||
since="0.15.0", | ||
)(utils.format_meas_map) | ||
|
||
measure = deprecate_function('"measure" has been moved to "qiskit.pulse.macros"', since="0.15.0")( | ||
macros.measure | ||
) | ||
|
||
measure_all = deprecate_function( | ||
'"measure_all" has been moved to "qiskit.pulse.macros"', since="0.15.0" | ||
)(macros.measure_all) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good thing that we're getting rid of this, because it will have been breaking the documentation of qiskit.pulse.macros.measure_all
(etc) because deprecate_function
/deprecate_func
mutate their inputs. Fortunately it looks like we don't actually seem to document those inner functions, only the pulse.builder.measure_all
wrapper around it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if I understand the question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing you need to change, it was just a comment about how this deprecation was broken by #9790, but fortunately it won't actually have leaked out to users.
had been moved to :func:`qiskit.pulse.utils.format_meas_map`, :func:`qiskit.pulse.macros.measure`, | ||
and :func:`qiskit.pulse.macros.measure_all` respectively. The previous location was deprecated | ||
in Qiskit 0.20.0 (Terra 0.15.0, released on 2020-08-10) and it is not longer supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain that the cross-references here will resolve. It's not clear to me whether those functions are actually meant to be used directly or documented - seems to me a little more that they're only meant to be called via the pulse builder interface, such as the wrapper pulse.builder.measure_all
?
(Also, "not longer supported" -> "no longer supported".)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross reference (and typo) removed in 55b3b7e
Summary
The functions
qiskit.scheduler.utils.format_meas_map
,qiskit.scheduler.utils.measure
, andqiskit.scheduler.utils.measure_all
had been moved toqiskit.pulse.utils.format_meas_map
,qiskit.pulse.macros.measure
, andqiskit.pulse.macros.measure_all
respectively. The previous location was deprecated in Qiskit 0.20.0 (Terra 0.15.0, released on 2020-08-10) and it is not longer supported.