Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing empty lists to Pauli delete method (backport #10849) #10896

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 23, 2023

This is an automatic backport of pull request #10849 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* handle empty lists in delete methods, added release notes

* fixed ordering of empty list check in pauli delete method

* add proper cross-references to classes

Co-authored-by: Jake Lishman <jake@binhbar.com>

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
(cherry picked from commit 6a38279)
@mergify mergify bot requested review from ikkoham and a team as code owners September 23, 2023 01:19
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators) labels Sep 23, 2023
@github-actions github-actions bot added this to the 0.25.2 milestone Sep 23, 2023
@github-actions github-actions bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 23, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6280715331

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 87.26%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
qiskit/extensions/unitary.py 1 93.75%
crates/qasm2/src/lex.rs 4 91.16%
Totals Coverage Status
Change from base Build 6276447995: -0.005%
Covered Lines: 74136
Relevant Lines: 84960

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Sep 23, 2023
@jakelishman jakelishman removed the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 23, 2023
Merged via the queue into stable/0.25 with commit 9361538 Sep 23, 2023
16 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.25/pr-10849 branch September 23, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants