Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PTM and Chi documentation #10909

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix PTM and Chi documentation #10909

merged 2 commits into from
Sep 28, 2023

Conversation

kevinsung
Copy link
Contributor

@kevinsung kevinsung commented Sep 27, 2023 •
edited
Loading

Summary

Fixes #10908
Fixes #10854

Details and comments

@kevinsung kevinsung requested review from ikkoham and a team as code owners September 27, 2023 21:09
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham

@kevinsung kevinsung mentioned this pull request Sep 27, 2023
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6331469134

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 87.011%
Files with Coverage Reduction New Missed Lines %
qiskit/pulse/library/waveform.py 3 93.75%
crates/qasm2/src/lex.rs 4 91.41%
crates/qasm2/src/parse.rs 12 97.13%
Totals Coverage Status
Change from base Build 6329969070: -0.01%
Covered Lines: 74089
Relevant Lines: 85149
💛 - Coveralls

@kevinsung kevinsung changed the title fix PTM documentation fix PTM and Chi documentation Sep 27, 2023
@ikkoham ikkoham added documentation Something is not clear or an error documentation mod: quantum info Related to the Quantum Info module (States & Operators) labels Sep 28, 2023
ikkoham
ikkoham approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you!

jakelishman
jakelishman approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks in agreement with what was discussed, thanks!

@jakelishman jakelishman added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Sep 28, 2023
@jakelishman jakelishman added this to the 0.25.2 milestone Sep 28, 2023
@jakelishman jakelishman added this pull request to the merge queue Sep 28, 2023
Merged via the queue into Qiskit:main with commit e636991 Sep 28, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Sep 28, 2023
@kevinsung @mergify
fix PTM and Chi documentation (#10909)
dcda504 
* fix PTM documentation

* fix chi matrix documentation too

(cherry picked from commit e636991)
@mergify mergify bot mentioned this pull request Sep 28, 2023
Merged
@kevinsung kevinsung deleted the ptm-doc branch September 28, 2023 11:21
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
@mergify @kevinsung
fix PTM and Chi documentation (#10909) (#10911)
05f2402 
* fix PTM documentation

* fix chi matrix documentation too

(cherry picked from commit e636991)

Co-authored-by: Kevin J. Sung <kevjsung@umich.edu>
@1ucian0 1ucian0 added the Changelog: None Do not include in changelog label Sep 28, 2023
rupeshknn pushed a commit to rupeshknn/qiskit that referenced this pull request Oct 9, 2023
@kevinsung @rupeshknn
fix PTM and Chi documentation (Qiskit#10909)
85d6179 
* fix PTM documentation

* fix chi matrix documentation too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@ikkoham ikkoham ikkoham approved these changes

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation mod: quantum info Related to the Quantum Info module (States & Operators) stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
No open projects
Qiskit Sphinx Theme
Status: Done
Milestone
0.25.2
Development

Successfully merging this pull request may close these issues.

PTM documentation is incorrect quantum_info.Chi documentation has incorrect normalization convention
6 participants
@kevinsung @qiskit-bot @coveralls @jakelishman @ikkoham @1ucian0