Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic circuit in BackendEstimator (backport #9700) #10984

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 6, 2023

This is an automatic backport of pull request #9700 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Support dynamic circuit in Estimator

* fix lint

* revert the validation condition

* fix test

* add reno

* separate measurements

* lint

* add test and bug fix reno

* fix reno

* revise tests and fix typo

---------

Co-authored-by: Takashi Imamichi <imamichi@jp.ibm.com>
(cherry picked from commit 660448c)
@mergify mergify bot requested review from ikkoham, t-imamichi and a team as code owners October 6, 2023 06:25
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @t-imamichi

@github-actions github-actions bot added priority: high Changelog: Bugfix Include in the "Fixed" section of the changelog mod: primitives Related to the Primitives module labels Oct 6, 2023
@github-actions github-actions bot added this to the 0.25.3 milestone Oct 6, 2023
@coveralls
Copy link

coveralls commented Oct 6, 2023

Pull Request Test Coverage Report for Build 6472429404

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 87.242%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/primitives/backend_estimator.py 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
qiskit/extensions/unitary.py 1 93.75%
crates/qasm2/src/lex.rs 4 90.91%
Totals Coverage Status
Change from base Build 6472106006: 0.02%
Covered Lines: 74130
Relevant Lines: 84971

💛 - Coveralls

@ikkoham ikkoham added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2023
@t-imamichi t-imamichi added this pull request to the merge queue Oct 11, 2023
Merged via the queue into stable/0.25 with commit 4b00427 Oct 11, 2023
15 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.25/pr-9700 branch October 11, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: primitives Related to the Primitives module priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants