Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build filter coupling map with mix ideal/physical targets (backport #11009) #11049

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 19, 2023

This is an automatic backport of pull request #11009 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Fix build filter coupling map with mix ideal/physical targets

This commit fixes a small issue in the Target.build_coupling_map method
with filter_idle_qubits=True. Previously the internal method used to
filter the idle qubits from the coupling map's creation was not
accounting for the case that an instruction in the target could be
ideal. This was never caught because normally if you have an ideal fixed
width instruction in the target that is modelling a simulator which
doesn't have any connectivity constraints and the function would never
be called. But in targets that have a mix of both ideal globally
defined and physical gates the filter code couldn't handle the None used
to represent an ideal globally available gate. This commit fixes that
handling to just ignore the global gate like the normal coupling map
construction does.

* Fix lint

(cherry picked from commit 4dfcba2)
@mergify mergify bot requested a review from a team as a code owner October 19, 2023 14:52
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Oct 19, 2023
@github-actions github-actions bot added this to the 0.25.3 milestone Oct 19, 2023
@coveralls
Copy link

coveralls commented Oct 19, 2023

Pull Request Test Coverage Report for Build 6630641889

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 87.248%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.16%
crates/qasm2/src/parse.rs 12 97.13%
Totals Coverage Status
Change from base Build 6628507089: -0.01%
Covered Lines: 74150
Relevant Lines: 84988

💛 - Coveralls

@jakelishman
Copy link
Member

This PR is still due to be backported to stable/0.25, I've just killed its tests to free up some CI throughput ahead of the 0.45.0rc1 release. We can re-run them once we've got spare CI again.

@jakelishman jakelishman added this pull request to the merge queue Oct 24, 2023
Merged via the queue into stable/0.25 with commit 79308e1 Oct 24, 2023
15 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.25/pr-11009 branch October 24, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants