Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phase in readme state #11259

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix phase in readme state #11259

merged 1 commit into from
Nov 16, 2023

Conversation

jakelishman
Copy link
Member

Summary

Looks like an $i$ got lost from the equation, given what the example circuit does.

Details and comments

@jakelishman jakelishman added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Nov 16, 2023
@jakelishman jakelishman requested a review from a team as a code owner November 16, 2023 14:45
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6892344892

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 85.917%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 92.17%
Totals Coverage Status
Change from base Build 6892258856: 0.04%
Covered Lines: 65954
Relevant Lines: 76765
💛 - Coveralls

ElePT
ElePT approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we also backport the fix?

@jakelishman
Copy link
Member Author

We can do, though I'm not really sure if it matters for the readme.

@1ucian0 1ucian0 added this pull request to the merge queue Nov 16, 2023
@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 16, 2023
@mtreinish
Copy link
Member

Since we publish the readme on https://pypi.org/project/qiskit/ and https://pypi.org/project/qiskit-terra/ I labelled this for stable backport.

Merged via the queue into Qiskit:main with commit fced4bf Nov 16, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 16, 2023
@jakelishman @mergify
Fix phase in readme state (#11259)
5e4f05d 
(cherry picked from commit fced4bf)
@mergify mergify bot mentioned this pull request Nov 16, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 17, 2023
@mergify @jakelishman
Fix phase in readme state (#11259) (#11263)
4b1d392 
(cherry picked from commit fced4bf)

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
@jakelishman jakelishman deleted the fix-readme-phase branch November 17, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucian0 1ucian0 1ucian0 approved these changes

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakelishman @qiskit-bot @coveralls @mtreinish @1ucian0 @ElePT