Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated IntegerComparator.num_ancilla_qubits #11306

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 23, 2023

The property IntegerComparator.num_ancilla_qubits was deprecated in https://github.com/Qiskit/qiskit/pull/5079/files (released with Qiskit Terra 0.16.0 - Oct 2020) but it never raised a DeprecationWarning. I think it is safe to remove it tho.

@1ucian0 1ucian0 added the Changelog: Removal Include in the Removed section of the changelog label Nov 23, 2023
@1ucian0 1ucian0 requested a review from a team as a code owner November 23, 2023 10:39
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6968648740

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.007%) to 86.447%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 1 92.17%
crates/qasm2/src/parse.rs 6 97.13%
Totals Coverage Status
Change from base Build 6966472058: 0.007%
Covered Lines: 66286
Relevant Lines: 76678

💛 - Coveralls

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it wasn't raising a DeprecationWarning, but it will have been raising a visible regular warning - we might not have followed the exact letter of our law, but we got the spirit. I think that's acceptable.

@jakelishman jakelishman added this pull request to the merge queue Nov 23, 2023
Merged via the queue into Qiskit:main with commit 7f6d437 Nov 23, 2023
14 checks passed
FabianBrings pushed a commit to FabianBrings/qiskit that referenced this pull request Nov 27, 2023
* remove deprecated IntegerComparator.num_ancilla_qubits

* reno
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants