Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate leftover algorithm/opflow utils #11323

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Nov 27, 2023

Summary

This PR deprecates a series of util functions that were only used in the context of algorithms/opflow, and are no longer necessary. These will be removed in 1.0.

Details and comment

@ElePT ElePT added this to the 0.46.0 milestone Nov 27, 2023
@ElePT ElePT added the Changelog: Deprecation Include in "Deprecated" section of changelog label Nov 27, 2023
@ElePT ElePT marked this pull request as ready for review November 27, 2023 13:27
@ElePT ElePT requested review from woodsp-ibm and a team as code owners November 27, 2023 13:27
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @ElePT
  • @Qiskit/terra-core
  • @woodsp-ibm

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look largely sensible to me, release-note change aside.

Comment on lines 6 to 9
* Utils in ``qiskit.utils.arithmetic.py``
* Utils in ``qiskit.utils.circuit_utils.py``
* Utils in ``qiskit.utils.entangler_map.py``
* Utils in ``qiskit.utils.name_unnamed_args.py``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #11324 - I think the .py maybe wants dropping?

@jakelishman jakelishman added this pull request to the merge queue Nov 28, 2023
Merged via the queue into Qiskit:stable/0.46 with commit 3784358 Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants