Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instruction.condition_bits for runtime classical expressions (backport #11325) #11328

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 27, 2023

This is an automatic backport of pull request #11325 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…#11325)

I didn't even know this property existed and it wasn't tested directly,
but the IBM provider uses it during its custom scheduling passes, so
until removal, it should be kept updated.

(cherry picked from commit 5bbda4a)
@mergify mergify bot requested a review from a team as a code owner November 27, 2023 20:17
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7010055208

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.009%) to 86.939%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.67%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 6985630422: 0.009%
Covered Lines: 74195
Relevant Lines: 85341

💛 - Coveralls

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Nov 27, 2023
@github-actions github-actions bot added this to the 1.0.0pre1 milestone Nov 27, 2023
auto-merge was automatically disabled November 28, 2023 11:17

Pull request was closed

@jakelishman jakelishman reopened this Nov 28, 2023
@jakelishman jakelishman added this pull request to the merge queue Nov 28, 2023
Merged via the queue into stable/0.45 with commit 1cded9b Nov 28, 2023
17 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.45/pr-11325 branch November 28, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants