Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to ASV conf. #11342

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add Python 3.12 to ASV conf. #11342

merged 1 commit into from
Nov 29, 2023

Conversation

kevinhartman
Copy link
Contributor

Summary

When we added support to Python 3.12, this was missed.

@kevinhartman kevinhartman added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Nov 29, 2023
@kevinhartman kevinhartman requested a review from a team as a code owner November 29, 2023 18:24
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish enabled auto-merge November 29, 2023 18:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7036896018

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 87.448%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 92.68%
Totals Coverage Status
Change from base Build 7035250835: 0.004%
Covered Lines: 59771
Relevant Lines: 68350

💛 - Coveralls

@jakelishman
Copy link
Member

I didn't even remember that asv asked for this haha.

@mtreinish mtreinish added this pull request to the merge queue Nov 29, 2023
Merged via the queue into Qiskit:main with commit c100c7b Nov 29, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 29, 2023
(cherry picked from commit c100c7b)

# Conflicts:
#	asv.conf.json
jakelishman pushed a commit that referenced this pull request Nov 29, 2023
github-merge-queue bot pushed a commit that referenced this pull request Nov 30, 2023
(cherry picked from commit c100c7b)

Co-authored-by: Kevin Hartman <kevin@hart.mn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants