Remove Optimize1qGatesDecomposition from init stage #11360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit#11354 we added more logical optimization passes to the preset pass managers for level 1, 2, and 3 which included the Optimize1qGatesDecomposition pass. However, this had the the unintended side effect of tending to normalize circuits to use parameterized gates. This becomes an issue for discrete basis targets as the basis translator doesn't always know how to work with those. To avoid issues this commit removes the pass from the init stage and just saves it for the optimization loop. If we want to do 1q gate simplification during init in the future we can develop a different pass that does it in a manner that wouldn't interfere with discrete basis targets like Optimize1qGatesDecomposition.
|
One or more of the the following people are requested to review this:
|
jakelishman
approved these changes
Dec 1, 2023
Pull Request Test Coverage Report for Build 7060027991
💛 - Coveralls |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #11354 we added more logical optimization passes to the preset pass managers for level 1, 2, and 3 which included the
Optimize1qGatesDecomposition pass. However, this had the the unintended side effect of tending to normalize circuits to use parameterized gates. This becomes an issue for discrete basis targets as the basis translator doesn't always know how to work with those. To avoid issues this commit removes the pass from the init stage and just saves it for the optimization loop. If we want to do 1q gate simplification during init in the future we can develop a different pass that does it in a manner that wouldn't interfere with discrete basis targets like Optimize1qGatesDecomposition.
Details and comments