-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QuantumCircuit.get_parameter
to retrieve by name
#11431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
Changelog: New Feature
Include in the "Added" section of the changelog
mod: circuit
Related to the core of the `QuantumCircuit` class or the circuit library
labels
Dec 19, 2023
One or more of the the following people are requested to review this:
|
This was referenced Dec 19, 2023
Pull Request Test Coverage Report for Build 7422369056
💛 - Coveralls |
This allows `Parameter` instances to be retrieved from a circuit by string name. The interface is a mirror of the same functionality already added for run-time variables (`get_var`), but for the compile-time `Parameter` class. Similarly, a `has_parameter` method mirrors `has_var`.
jakelishman
force-pushed
the
parameter-by-name
branch
from
December 21, 2023 01:22
ce43b4d
to
da5038a
Compare
Now rebased and ready for review. |
Cryoris
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be very nice to have support for binding by parameter name, thanks! 🙂 I left some comments below.
Co-authored-by: Julien Gacon <gaconju@gmail.com>
jakelishman
force-pushed
the
parameter-by-name
branch
from
January 5, 2024 13:10
b4b0b99
to
676b660
Compare
Cryoris
approved these changes
Jan 8, 2024
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* Add `QuantumCircuit.get_parameter` to retrieve by name This allows `Parameter` instances to be retrieved from a circuit by string name. The interface is a mirror of the same functionality already added for run-time variables (`get_var`), but for the compile-time `Parameter` class. Similarly, a `has_parameter` method mirrors `has_var`. * Update qiskit/circuit/parametertable.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Fix typos Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> * Fix blank space --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: New Feature
Include in the "Added" section of the changelog
mod: circuit
Related to the core of the `QuantumCircuit` class or the circuit library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows
Parameter
instances to be retrieved from a circuit by string name. The interface is a mirror of the same functionality already added for run-time variables (get_var
), but for the compile-timeParameter
class. Similarly, ahas_parameter
method mirrorshas_var
.Details and comments
Depends on #11428, which this PR currently includes.Now up to date.