Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcasting of QuantumCircuit.delay (backport #11447) #11523

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 9, 2024

This is an automatic backport of pull request #11447 done by Mergify.
Cherry-pick of 4c6eed9 has failed:

On branch mergify/bp/stable/0.45/pr-11447
Your branch is up to date with 'origin/stable/0.45'.

You are currently cherry-picking commit 4c6eed9b6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   qiskit/circuit/delay.py
	new file:   releasenotes/notes/fix-delay-broadcast-e8762b01dfd7e94f.yaml
	modified:   test/python/circuit/test_delay.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   qiskit/circuit/quantumcircuit.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner January 9, 2024 15:24
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Jan 9, 2024
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Jan 9, 2024
@github-actions github-actions bot added this to the 0.45.2 milestone Jan 9, 2024
The object is supposed to "broadcast" like a gate; one instruction per
qubit.  This silently did the wrong thing when given a `set` as its
argument, previously.

(cherry picked from commit 4c6eed9)
@jakelishman jakelishman force-pushed the mergify/bp/stable/0.45/pr-11447 branch from d41043c to 1ace14a Compare January 9, 2024 16:39
@jakelishman jakelishman removed the conflicts used by mergify when there are conflicts in a port label Jan 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7464087893

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 86.944%

Totals Coverage Status
Change from base Build 7437958387: 0.03%
Covered Lines: 74236
Relevant Lines: 85384

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Jan 9, 2024
Merged via the queue into stable/0.45 with commit 7fb6acc Jan 9, 2024
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.45/pr-11447 branch January 9, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants