-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make iqp
the matplotlib default style
#11536
Conversation
Pull Request Test Coverage Report for Build 7528651301Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
some img will still need updating
One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are still a few lint complains to fix. I think that the docs failures might get resolved after merging from main (at least that was the case for a PR I had with the same issues.
I think the docs failure is local to this PR - the actual errors are these:
They're both probably because a bullet list is starting on the first continuation line - it likely wants a blank line before (and maybe after) the start of the list in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving in hopes that lint passes this time :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary tests passing! I'll re-approve and hope for no further surprises.
* First try * set IQP as default * delete IQX as name * remove "False" for bw * refactor default style dict * Missing future annotations, revert img threshold * lint * Update ref images and fix dict loading some img will still need updating * Fix loading of styles via dict * Fix usage of stylename and iqx usage * Fix default font ratio * Update creg_initial_true img * cleanup * add reno * Attempt 1 to gain Sphinx' goodwill * thou shalt make lint * thou shan't change default values --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Summary
Following #10950, this PR sets
"iqp"
as the new default for the matplotlib drawer.Note: Due to the apparent impossibility of reproducing the precise matplotlib drawings locally I'm abusing the CI to generate the correct images, hence, opening this early draft PR.
Details and comments
In addition, this PR includes some additional changes
style="bw"
instead ofstyle=False
. This is a suggestion for a more consistent interface, the deprecation would be out into 0.46.DefaultStyle
to not hardcode the default colors but load it from a JSON, such as all other color schemes.StyleDict
, which is a dictionary handling matplotlib-specific aliases (such as "ec" for "edgecolor") instead of keeping a dictionary with duplicate entries.