Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional sympy imports #11662

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Remove optional sympy imports #11662

merged 5 commits into from
Jan 29, 2024

Conversation

TsafrirA
Copy link
Collaborator

Summary

#10902 promoted symengine to a hard requirement with the aim of supporting only it, and not sympy. However, few optional sympy imports remained in the tests. This PR removes these optional imports.

@TsafrirA TsafrirA requested review from eggerdj, wshanks and a team as code owners January 29, 2024 10:11
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

ElePT
ElePT previously approved these changes Jan 29, 2024
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT dismissed their stale review January 29, 2024 10:30

Just realized that the formatting CI run is failing, I'll re-approve once you run tox -eblack

@coveralls
Copy link

coveralls commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7697207518

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 89.555%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.94%
Totals Coverage Status
Change from base Build 7695410601: 0.004%
Covered Lines: 59555
Relevant Lines: 66501

💛 - Coveralls

@ElePT ElePT enabled auto-merge January 29, 2024 14:04
@ElePT ElePT added this pull request to the merge queue Jan 29, 2024
Merged via the queue into Qiskit:main with commit 042a1a1 Jan 29, 2024
12 checks passed
@TsafrirA TsafrirA deleted the optionalsymengine branch January 30, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants