Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement __array__ for qasm2._DefinedGate (backport #12119) #12523

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 6, 2024

Summary

Gates defined from OpenQASM 2 should have a well-defined matrix form (up to global phase) whenever all the constituent parts of the definition do. This manually makes such a matrix available.

Details and comments

Fix #12100.


This is an automatic backport of pull request #12119 done by [Mergify](https://mergify.com).

* Implement `__array__` for `qasm2._DefinedGate`

Gates defined from OpenQASM 2 should have a well-defined matrix form (up
to global phase) whenever all the constituent parts of the definition
do. This manually makes such a matrix available.

* Fix signature for Numpy 2.0

(cherry picked from commit 767bd07)
@mergify mergify bot requested a review from a team as a code owner June 6, 2024 14:59
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: qasm2 Relating to OpenQASM 2 import or export labels Jun 6, 2024
@github-actions github-actions bot added this to the 1.1.1 milestone Jun 6, 2024
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9403194051

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 89.629%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/qasm2/parse.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.2%
crates/qasm2/src/lex.rs 5 92.62%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 9276092364: -0.005%
Covered Lines: 62259
Relevant Lines: 69463

💛 - Coveralls

@mtreinish mtreinish enabled auto-merge June 6, 2024 16:07
@mtreinish mtreinish added this pull request to the merge queue Jun 6, 2024
Merged via the queue into stable/1.1 with commit c148a5e Jun 6, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.1/pr-12119 branch June 6, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: qasm2 Relating to OpenQASM 2 import or export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants