Do not retain and expose old elements of ParameterVector
#12561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Qiskit#12541 according to Qiskit#12545 (review).
Pull Request Test Coverage Report for Build 9491859150Details
💛 - Coveralls |
|
One or more of the following people are relevant to this code:
|
jakelishman
added
Changelog: None
jakelishman
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Do not retain and expose old elements of `ParameterVector` This fixes #12541 according to #12545 (review). * Fix test (cherry picked from commit 8a1bcc2)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
…12565) * Do not retain and expose old elements of `ParameterVector` This fixes #12541 according to #12545 (review). * Fix test (cherry picked from commit 8a1bcc2) Co-authored-by: Jim Garrison <garrison@ibm.com>
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
) * Do not retain and expose old elements of `ParameterVector` This fixes Qiskit#12541 according to Qiskit#12545 (review). * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #12541 according to #12545 (review).
Details and comments
Note that qpy does not appear to store the
_root_uuid, so if one deserializes aParameterVectorand then removes elements and later adds new ones, the uuids of the regenerated elements will change.