Fix CircuitInstruction legacy iterable typing
#12630
Merged
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy 3-tuple format of `CircuitInstruction` still exposes the object in the old tuple-like way of `(Operation, list[Qubit], list[Clbit])`, rather than the new-style attribute access using tuples for the qargs and cargs. This was inadvertantly changed when it moved to Rust.
jakelishman
added
Changelog: None
|
One or more of the following people are relevant to this code:
|
ElePT
approved these changes
Jun 21, 2024
|
I opened #12631 to track deprecation - I'm just throwing together a PR to do it now too. |
Pull Request Test Coverage Report for Build 9612612289Details
💛 - Coveralls |
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
The legacy 3-tuple format of `CircuitInstruction` still exposes the object in the old tuple-like way of `(Operation, list[Qubit], list[Clbit])`, rather than the new-style attribute access using tuples for the qargs and cargs. This was inadvertantly changed when it moved to Rust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The legacy 3-tuple format of
CircuitInstructionstill exposes the object in the old tuple-like way of(Operation, list[Qubit], list[Clbit]), rather than the new-style attribute access using tuples for the qargs and cargs. This was inadvertantly changed when it moved to Rust.Details and comments
Fix #12626.
No changelog because it's not in a release version of Qiskit.