Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitarray postselect #12693

Merged
merged 51 commits into from
Jul 29, 2024
Merged

Bitarray postselect #12693

merged 51 commits into from
Jul 29, 2024

Commits on Jun 28, 2024

  1. define BitArray.postselect()

    @aeddins-ibm
    aeddins-ibm committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7495d59 View commit details
    Browse the repository at this point in the history

  2. add test for BitArray.postselect()

    @aeddins-ibm
    aeddins-ibm committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    757eda5 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. lint

    @aeddins-ibm
    aeddins-ibm committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    cb0bb69 View commit details
    Browse the repository at this point in the history

  2. remove redundant docstring text

    @aeddins-ibm
    aeddins-ibm committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    6079906 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Update qiskit/primitives/containers/bit_array.py 

    Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
    @aeddins-ibm @ihincks
    aeddins-ibm and ihincks authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    2e79728 View commit details
    Browse the repository at this point in the history

  2. docstring ticks (BitArray.postselect()) 

    Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
    @aeddins-ibm @ihincks
    aeddins-ibm and ihincks authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    033aa63 View commit details
    Browse the repository at this point in the history

  3. Simpler tests for BitArray.postselect

    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    efdad57 View commit details
    Browse the repository at this point in the history

  4. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8cb4920 View commit details
    Browse the repository at this point in the history

  5. add release note

    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b2b0a54 View commit details
    Browse the repository at this point in the history

  6. check postselect() arg lengths match

    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e080cf5 View commit details
    Browse the repository at this point in the history

  7. fix postselect tests 

    - fix bugs with checking that ValueError is raised.
- addtionally run all tests on a "flat" data input
    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9760e1d View commit details
    Browse the repository at this point in the history

  8. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    07a2ede View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into bitarray_postselect

    @aeddins-ibm
    aeddins-ibm authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ac720dc View commit details
    Browse the repository at this point in the history

  10. Fix type-hint 

    We immediately check the lengths of these args, so they should be Sequences, not Iterables.
    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    fd317bf View commit details
    Browse the repository at this point in the history

  11. Merge branch 'bitarray_postselect' of https://github.com/aeddins-ibm/… 

    …qiskit into bitarray_postselect
    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b114315 View commit details
    Browse the repository at this point in the history

  12. remove spurious print()

    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    124e567 View commit details
    Browse the repository at this point in the history

  13. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    82c5011 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ab87d66 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into bitarray_postselect

    @aeddins-ibm
    aeddins-ibm authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d03cbb0 View commit details
    Browse the repository at this point in the history

  3. use bitwise operations for faster postselect 

    - Also added support for negative indices
- Also updated tests
    @aeddins-ibm
    aeddins-ibm committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    09ec38a View commit details
    Browse the repository at this point in the history

  4. remove spurious print()

    @aeddins-ibm
    aeddins-ibm committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d688a2a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into bitarray_postselect

    @aeddins-ibm
    aeddins-ibm authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ae959d0 View commit details
    Browse the repository at this point in the history

  6. end final line of release note

    @aeddins-ibm
    aeddins-ibm authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ff580df View commit details
    Browse the repository at this point in the history

  7. try to fix docstring formatting

    @aeddins-ibm
    aeddins-ibm committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    17ac5ec View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. fix bitarray test assertion 

    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    @aeddins-ibm @t-imamichi
    aeddins-ibm and t-imamichi authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    2961544 View commit details
    Browse the repository at this point in the history

  2. disallow postselect positional kwarg 

    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    @aeddins-ibm @t-imamichi
    aeddins-ibm and t-imamichi authored Jul 5, 2024
    Configuration menu
    Copy the full SHA
    745130f View commit details
    Browse the repository at this point in the history

  3. fix numpy dtype args

    @aeddins-ibm
    aeddins-ibm committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    803765b View commit details
    Browse the repository at this point in the history

  4. Simpler kwarg: "assume_unique"

    @aeddins-ibm
    aeddins-ibm committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    99824f3 View commit details
    Browse the repository at this point in the history

  5. lint (line too long)

    @aeddins-ibm
    aeddins-ibm committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    bdd4ede View commit details
    Browse the repository at this point in the history

  6. simplification: remove assume_unique kwarg

    @aeddins-ibm
    aeddins-ibm committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6950687 View commit details
    Browse the repository at this point in the history

  7. improve misleading comment

    @aeddins-ibm
    aeddins-ibm committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    88be7a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Merge branch 'main' into bitarray_postselect

    @aeddins-ibm
    aeddins-ibm authored Jul 7, 2024
    Configuration menu
    Copy the full SHA
    5243067 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. raise IndexError if indices out of range 

    - Change ValueError to IndexError.
- Add check for out-of-range negative indices.
- Simplify use of mod
- Update test conditions (include checks for off-by-one errors)
    @aeddins-ibm
    aeddins-ibm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    036fdf8 View commit details
    Browse the repository at this point in the history

  2. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3e02934 View commit details
    Browse the repository at this point in the history

  3. add negative-contradiction test

    @aeddins-ibm
    aeddins-ibm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    da959ff View commit details
    Browse the repository at this point in the history

  4. Update docstring with IndexErrors

    @aeddins-ibm
    aeddins-ibm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8f76f97 View commit details
    Browse the repository at this point in the history

  5. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bfca1bd View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. change slice_bits error from ValueError to IndexError

    @aeddins-ibm
    aeddins-ibm authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8f32178 View commit details
    Browse the repository at this point in the history

  2. update slice_bits test to use IndexError

    @aeddins-ibm
    aeddins-ibm committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c2b0039 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. change ValueError to IndexError in slice_shots 

    also update tests for this error
    @aeddins-ibm
    aeddins-ibm committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c4becd9 View commit details
    Browse the repository at this point in the history

  2. update error type in slice_shots docstring

    @aeddins-ibm
    aeddins-ibm committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    50545ef View commit details
    Browse the repository at this point in the history

  3. Revert ValueError to IndexError changes 

    Reverting these changes as they will instead be made in a separate PR.

This reverts commit 8f32178.

Revert "update error type in slice_shots docstring"

This reverts commit 50545ef.

Revert "change ValueError to IndexError in slice_shots"

This reverts commit c4becd9.

Revert "update slice_bits test to use IndexError"

This reverts commit c2b0039.
    @aeddins-ibm
    aeddins-ibm committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    95bb321 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fix docstring formatting 

    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    @aeddins-ibm @t-imamichi
    aeddins-ibm and t-imamichi authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c140f8d View commit details
    Browse the repository at this point in the history

  2. allow selection to be int instead of bool

    @aeddins-ibm
    aeddins-ibm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    38155e4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bitarray_postselect' of https://github.com/aeddins-ibm/… 

    …qiskit into bitarray_postselect
    @aeddins-ibm
    aeddins-ibm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    af369c9 View commit details
    Browse the repository at this point in the history

  4. In tests, give selection as type int

    @aeddins-ibm
    aeddins-ibm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c129642 View commit details
    Browse the repository at this point in the history

  5. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    af39354 View commit details
    Browse the repository at this point in the history

  6. add example to release note

    @aeddins-ibm
    aeddins-ibm committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    9c5edcd View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. fix typo in test case

    @aeddins-ibm
    aeddins-ibm committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3e9684e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. add check of test 

    Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
    @aeddins-ibm @t-imamichi
    aeddins-ibm and t-imamichi authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4750250 View commit details
    Browse the repository at this point in the history

  2. lint

    @aeddins-ibm
    aeddins-ibm committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d5d0009 View commit details
    Browse the repository at this point in the history