Expose operation conversion methods to other crates. #12698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expose `operation_type_to_py`, `operation_type_and_data_to_py`, `convert_py_to_operation_type`, methods to other rust crates. - Expose `OperationTypeConstruct` struct to other crates.
|
One or more of the following people are relevant to this code:
|
raynelfss
added
the
Rust
|
Can you add some motivation? Is there something in the works that intends to use these methods? |
|
@jlapeyre, Here's one use case: This is the way we represent gates within the EquivalenceLibrary as we still need to check the parameters that are used within each |
Pull Request Test Coverage Report for Build 9747010175Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
6 tasks
jlapeyre
approved these changes
Jul 1, 2024
3 tasks
Procatv
pushed a commit
to Procatv/qiskit-terra-catherines
that referenced
this pull request
Aug 1, 2024
…#12698) - Expose `operation_type_to_py`, `operation_type_and_data_to_py`, `convert_py_to_operation_type`, methods to other rust crates. - Expose `OperationTypeConstruct` struct to other crates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #12459 merged, a couple of conversion methods were introduced to be able to represent operations in Rust. These commits aim to expose these methods so that they can be used on other crates within
qiskit._accelerate. One example of its use is for #12585.Details and comments
operation_type_to_py,operation_type_and_data_to_py,convert_py_to_operation_type, methods to other rust crates.OperationTypeConstructstruct to other crates.