Revert base class change introduced in Primitives V1 deprecation (backport #12871) #12873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: None
mtreinish
approved these changes
Jul 31, 2024
Pull Request Test Coverage Report for Build 10186771080Details
💛 - Coveralls |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
mtreinish
force-pushed
the
mergify/bp/stable/1.2/pr-12871
branch
from
6312c70
to
8d635a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#12575 deprecated the non-versioned aliases for the V1 interfaces of the primitives as well as the V1 implementations. The base class of the deprecated implementations was changed from the non-versioned to the versioned class, and looking back I think this change should be reverted.
This change breaks instance checks on implementations based on the primitives, and prevents the deprecation warning from being raised properly. Given that the implementations are deprecated and will be removed as the same time as the base class aliases, we didn't really gain much from changing to an un-deprecated base class, and I think it is safer to keep the base classes unchanged and preserve the instance checks.
Details and comments
This is an automatic backport of pull request #12871 done by [Mergify](https://mergify.com).