Allow arbitrary iterables in assign_parameters
#12887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Qiskit 1.1, it was possible to give any object that was iterable and had a `__len__` as the binding sequence for `assign_parameters`. The move to Rust space inadvertantly limited that to things that fulfilled the sequence API. This commit restores the ability to use general iterables, and removes the need to have a `__len__`.
jakelishman
added
stable backport potential
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10212978644Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Cryoris
approved these changes
Aug 2, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
In Qiskit 1.1, it was possible to give any object that was iterable and had a `__len__` as the binding sequence for `assign_parameters`. The move to Rust space inadvertantly limited that to things that fulfilled the sequence API. This commit restores the ability to use general iterables, and removes the need to have a `__len__`. (cherry picked from commit 9de8119)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
In Qiskit 1.1, it was possible to give any object that was iterable and had a `__len__` as the binding sequence for `assign_parameters`. The move to Rust space inadvertantly limited that to things that fulfilled the sequence API. This commit restores the ability to use general iterables, and removes the need to have a `__len__`. (cherry picked from commit 9de8119) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Qiskit 1.1, it was possible to give any object that was iterable and had a
__len__as the binding sequence forassign_parameters. The move to Rust space inadvertantly limited that to things that fulfilled the sequence API. This commit restores the ability to use general iterables, and removes the need to have a__len__.Details and comments
Fix #12885, but no release note because the bug isn't in a final release.