Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spaces to deprecation warning about qiskit.providers.models #12894

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add spaces to deprecation warning about qiskit.providers.models #12894

merged 1 commit into from
Aug 2, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented Aug 2, 2024

Summary

This adds some spaces that are currently missing in a deprecation warning.

Details and comments

I reviewed the other warnings added as part of the same PR (#12629), and all the others looked correct to me.

@garrison garrison requested review from jyu00 and a team as code owners August 2, 2024 16:15
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

jakelishman
jakelishman approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Aug 2, 2024
@jakelishman jakelishman added this to the 1.2.0 milestone Aug 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10218717530

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.75%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/two_qubit_decompose.rs 1 90.67%
crates/qasm2/src/lex.rs 2 93.48%
crates/qasm2/src/parse.rs 6 97.61%
Totals Coverage Status
Change from base Build 10217580379: 0.02%
Covered Lines: 67344
Relevant Lines: 75035
💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Aug 2, 2024
Merged via the queue into Qiskit:main with commit ebb86b0 Aug 2, 2024
14 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
@garrison @mergify
Add spaces to deprecation warning about qiskit.providers.models (#1…
f8adadc 
…2894)

(cherry picked from commit ebb86b0)
@mergify mergify bot mentioned this pull request Aug 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 2, 2024
@mergify @garrison
Add spaces to deprecation warning about qiskit.providers.models (#1…
db260b6 
…2894) (#12895)

(cherry picked from commit ebb86b0)

Co-authored-by: Jim Garrison <garrison@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 is a code owner

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@garrison @qiskit-bot @coveralls @jakelishman