Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate BackendV1 in PassManagerConfig.from_backend #12931

Merged
merged 6 commits into from
Sep 12, 2024
Merged

deprecate BackendV1 in PassManagerConfig.from_backend #12931

merged 6 commits into from
Sep 12, 2024

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Aug 9, 2024

A follow up from #12629

@1ucian0 1ucian0 changed the title deprecate BackendV1 in PassManagerConfig.from_backend deprecate BackendV1 in PassManagerConfig.from_backend Aug 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10811328798

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.002%) to 88.868%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/accelerate/src/two_qubit_decompose.rs 1 90.82%
crates/qasm2/src/lex.rs 2 91.73%
crates/qasm2/src/parse.rs 6 97.15%
Totals Coverage Status
Change from base Build 10802845750: 0.002%
Covered Lines: 73099
Relevant Lines: 82256
💛 - Coveralls

@1ucian0 1ucian0 marked this pull request as ready for review September 11, 2024 19:11
@1ucian0 1ucian0 requested review from a team as code owners September 11, 2024 19:11
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @ajavadia
  • @levbishop
  • @t-imamichi

@1ucian0 1ucian0 added this to the 1.3.0 milestone Sep 11, 2024
@t-imamichi
Copy link
Member

primitive part looks good

ElePT
ElePT approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Sep 12, 2024
Merged via the queue into Qiskit:main with commit 2fa6dd6 Sep 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@1ucian0 @coveralls @qiskit-bot @t-imamichi @ElePT