-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to add instructions to a DAGCircuit from an iterator of PackedInstruction #13032
Commits on Sep 4, 2024
-
Initial: Add add_from_iter method to DAGCircuit
- Introduce a method that adds a chain of `PackedInstruction` continuously avoiding the re-linking of each bit's output-node until the very end of the iterator. - TODO: Add handling of vars - Add header for a `from_iter` function that will create a `DAGCircuit` based on a chain of `PackedInstruction`.
Configuration menu - View commit details
-
Copy full SHA for 22cdeb5 - Browse repository at this point
Copy the full SHA 22cdeb5View commit details -
Fix: leverage new methods in layers
- Fix incorrect re-insertion of last_node.
Configuration menu - View commit details
-
Copy full SHA for a4ed753 - Browse repository at this point
Copy the full SHA a4ed753View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cf7417 - Browse repository at this point
Copy the full SHA 5cf7417View commit details -
Fix: Incorrect modification of last nodes in
add_from_iter
.- Use `entry` api to either modify or insert a value if missing.
Configuration menu - View commit details
-
Copy full SHA for e6c4fff - Browse repository at this point
Copy the full SHA e6c4fffView commit details -
Fix: Cycling edges in when adding vars.
- A bug that adds duplicate edges to vars has been temporarily fixed. However, the root of this problem hasn't been found yet. A proper fix is pending. For now skip those instances.
Configuration menu - View commit details
-
Copy full SHA for 24c8b6a - Browse repository at this point
Copy the full SHA 24c8b6aView commit details -
Fix: Remove set collecting all nodes to be connected.
- A set collecting all the new nodes to connect with a new node was preventing additional wires to connect to subsequent nodes.
Configuration menu - View commit details
-
Copy full SHA for 0821aff - Browse repository at this point
Copy the full SHA 0821affView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcf674b - Browse repository at this point
Copy the full SHA dcf674bView commit details -
Refactor:
add_from_iter
is now calledextend
to stick withRust
…… nomenclature.
Configuration menu - View commit details
-
Copy full SHA for 3cb950e - Browse repository at this point
Copy the full SHA 3cb950eView commit details -
- Caught by @ElePT Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ff4b6eb - Browse repository at this point
Copy the full SHA ff4b6ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8011fdf - Browse repository at this point
Copy the full SHA 8011fdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ee5b40 - Browse repository at this point
Copy the full SHA 2ee5b40View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2b765b7 - Browse repository at this point
Copy the full SHA 2b765b7View commit details
Commits on Sep 6, 2024
-
Fix: Corrections from code review.
- Use Entry API to modify last nodes in the var. - Build new_nodes with an allocated vec. - Add comment explaining the removal of the edge between the output node and its predecessor.
Configuration menu - View commit details
-
Copy full SHA for 468869c - Browse repository at this point
Copy the full SHA 468869cView commit details -
Fix: Improper use of
Entry API
.- Use `or_insert_with` instead of `or_insert` to perform actions before inserting a value.
Configuration menu - View commit details
-
Copy full SHA for d846cd0 - Browse repository at this point
Copy the full SHA d846cd0View commit details