Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Interner::with_capacity for default keys #13092

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix Interner::with_capacity for default keys #13092

merged 1 commit into from
Sep 5, 2024
+26 −7

Conversation

jakelishman
Copy link
Member

Summary

The new method did not account for allocating the default key, causing code that then tried to use it to panic.

Details and comments

No changelog because the bug isn't released.

@jakelishman
Fix Interner::with_capacity for default keys
74a1f91 
The new method did not account for allocating the default key, causing
code that then tried to use it to panic.
@jakelishman jakelishman added Changelog: None Do not include in changelog Rust This PR or issue is related to Rust code in the repository mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Sep 5, 2024
@jakelishman jakelishman requested a review from a team as a code owner September 5, 2024 10:26
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @kevinhartman
  • @mtreinish

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10718577078

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 33 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 89.141%
Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.43%
crates/qasm2/src/lex.rs 6 91.23%
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 7 90.84%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 10717386257: -0.04%
Covered Lines: 72582
Relevant Lines: 81424
💛 - Coveralls

ElePT
ElePT approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing one of my sources of headache :) (I pulled the PR and confirmed it does fix it)

@ElePT ElePT enabled auto-merge September 5, 2024 11:03
@ElePT ElePT mentioned this pull request Sep 5, 2024
Merged
2 tasks
@ElePT ElePT added this pull request to the merge queue Sep 5, 2024
Merged via the queue into Qiskit:main with commit 86c63eb Sep 5, 2024
15 checks passed
@jakelishman jakelishman deleted the fix-interner-with_capacity branch September 5, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library Rust This PR or issue is related to Rust code in the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakelishman @qiskit-bot @coveralls @ElePT