Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Split2QUnitaries to run on UnitaryGates only (backport #13095) #13097

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2024

Summary

Fixes the remaining problems with #12970.

Details and comments

If we run Split2QUnitaries with an incomplete 1-q basis gate set, we can end up in the situation where a supported gate is split into 2 UnitaryGate objects that might not be representable in the current basis gate set. For example

from qiskit import QuantumCircuit, transpile
from qiskit.circuit.library import *

gate = PauliGate("XX")

qc = QuantumCircuit(2)
qc.append(gate, [0, 1])

basis_gates = ["x"]  # gate decomposes into XX
 
circuit = transpile(qc, basis_gates=basis_gates, optimization_level=2)  # fails -- cannot map U to the basis

This PR fixes the behavior by only running on UnitaryGate objects -- hence not changing the gate types existing in the circuit.


This is an automatic backport of pull request #13095 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 5, 2024 17:22
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Sep 5, 2024
@github-actions github-actions bot added this to the 1.2.1 milestone Sep 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10725172384

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.005%) to 89.779%

Files with Coverage Reduction New Missed Lines %
crates/circuit/src/packed_instruction.rs 1 96.21%
crates/accelerate/src/results/marginalization.rs 1 90.45%
crates/accelerate/src/synthesis/clifford/utils.rs 1 78.06%
crates/qasm2/src/lex.rs 2 92.98%
crates/circuit/src/circuit_instruction.rs 7 86.33%
crates/circuit/src/operations.rs 7 88.31%
Totals Coverage Status
Change from base Build 10719167310: 0.005%
Covered Lines: 66861
Relevant Lines: 74473

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Sep 5, 2024
Merged via the queue into stable/1.2 with commit f5a73ad Sep 6, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-13095 branch September 6, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants