Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the matrix representation of CUGate in Rust (backport #13121) #13124

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 10, 2024

Summary

Fixed #13118.

Details and comments

The matrix representation of CUGate in Rust accidentally swapped two arguments (phi and lam). This didn't fail the tests, because there all parameters are set to the same value. The tests are therefore also updated to vary the parameters values within a gate.


This is an automatic backport of pull request #13121 done by [Mergify](https://mergify.com).

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
(cherry picked from commit 8929e12)
@mergify mergify bot requested a review from a team as a code owner September 10, 2024 16:17
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @kevinhartman
  • @mtreinish

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Sep 10, 2024
@github-actions github-actions bot added this to the 1.2.1 milestone Sep 10, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10796538236

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 89.791%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 8 91.73%
Totals Coverage Status
Change from base Build 10735835379: 0.01%
Covered Lines: 66870
Relevant Lines: 74473

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Sep 10, 2024
Merged via the queue into stable/1.2 with commit 9a393f1 Sep 10, 2024
18 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.2/pr-13121 branch September 10, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants