Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cibuildwheel to unblock 0.46.3 release #13159

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Update cibuildwheel to unblock 0.46.3 release #13159

merged 2 commits into from
Sep 17, 2024

Conversation

ElePT
Copy link
Contributor

@ElePT ElePT commented Sep 16, 2024

@ElePT ElePT changed the title Fix 0.46 build job failure Fix wheel building for 0.46.3 Sep 16, 2024
@ElePT ElePT changed the title Fix wheel building for 0.46.3 Update cibuildwheel to unblock 0.46.3 release Sep 16, 2024
@ElePT ElePT added this to the 0.46.3 milestone Sep 16, 2024
@ElePT ElePT added the Changelog: None Do not include in changelog label Sep 16, 2024
@ElePT ElePT marked this pull request as ready for review September 16, 2024 16:01
@ElePT ElePT requested a review from a team as a code owner September 16, 2024 16:01
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

kevinhartman
kevinhartman previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming it resolves the issue 😉.

@eliarbel
Copy link
Contributor

eliarbel commented Sep 17, 2024 •
edited
Loading

I'm not sure this will work...

Running cibuildwheel version 2.16.5 (the one CI used for 0.46.3) locally, I get this:

Error response from daemon: pull access denied for manylinux2014-latest, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

So it seems there is no image named manylinux2014-latest.

Per cibuildwheel release notes, updating it to version 2.19.2 and restoring the image name to manylinux2014, the build was successful.

So I wonder, should we instead update cibuildwheel version for Linux in .github/workflows/wheels.yaml in the stable/0.46 branch?

@mtreinish @jakelishman

@ElePT
Copy link
Contributor Author

ElePT commented Sep 17, 2024

I applied your suggestion in ada6eab, @eliarbel. I think it looks very reasonable and seems to work locally.

jakelishman
jakelishman reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be ok. I was worried because sometimes we've had to change various bits of other configuration as we bump cibuildwheel, but it looks like when we did this bump on main, I just lazily abandoned the backport rather than fixing the minor merge conflicts that were to do with the subsequent addition of PGO: #12574.

That said, Elena: did the Linux build work locally for you, or just the macOS one?

@eliarbel
Copy link
Contributor

That said, Elena: did the Linux build work locally for you, or just the macOS one?

My local Linux build worked OK

@jakelishman jakelishman added this pull request to the merge queue Sep 17, 2024
Merged via the queue into Qiskit:stable/0.46 with commit ee2bd5c Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@kevinhartman kevinhartman kevinhartman left review comments

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog
Projects
None yet
Milestone
0.46.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ElePT @qiskit-bot @eliarbel @kevinhartman @jakelishman