Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qiskit-bot notification rule for rust changes (backport #13198) #13201

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 20, 2024

Summary

We previously had a qiskit-bot notification trigger for changes to the rust source or cargo configuration that would list myself and @kevinhartman as the relevant reviewers. While this is still true, as Qiskit is now >16% Rust (by lines of code, excluding tests) and that ratio will only grow over time, the two of us are hardly the only people worth calling out specifically as reviewers of rust code. Instead of expanding the list to include the entirety of the terra-core team individually this just removes the custom notification rule and opts to fallback to the default terra-core entry.

Details and comments
This is an automatic backport of pull request #13198 done by Mergify.

We previously had a qiskit-bot notification trigger for changes to the
rust source or cargo configuration that would list myself and
`@kevinhartman` as the relevant reviewers. While this is still true, as
Qiskit is now >16% Rust (by lines of code, excluding tests) and that
ratio will only grow over time, the two of us are hardly the only people
worth calling out specifically as reviewers of rust code. Instead of
expanding the list to include the entirety of the terra-core team
individually this just removes the custom notification rule and opts to
fallback to the default terra-core entry.

(cherry picked from commit 597f2b2)
@mergify mergify bot requested a review from a team as a code owner September 20, 2024 13:50
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Sep 20, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10960512499

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.758%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 6 91.98%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 10959931349: -0.02%
Covered Lines: 66877
Relevant Lines: 74508

💛 - Coveralls

@ElePT ElePT added this pull request to the merge queue Sep 20, 2024
Merged via the queue into stable/1.2 with commit bec0155 Sep 20, 2024
18 checks passed
@mtreinish mtreinish deleted the mergify/bp/stable/1.2/pr-13198 branch September 27, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants