-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CPhaseGate parameter name mismatch in API docs #13242
base: main
Are you sure you want to change the base?
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 11167381278Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
In the same file, we seem to have the same discrepancy between the argument name and the documented symbol in PhaseGate
- would you be able to swap that over to be consistent as well?
yes i will check this out. i had a question about notation i asked on the issue. it seems like changing the notation to theta rather than parameter to lambda is correct? |
i realized that the notation should be changed since the parameters are inferred from Controlled Gate |
@jakelishman later today or early am tomorrow. i can take a second to look for any more incorrect notation. |
should RZ gate be updated to change lambda in notation to match phi in parameters? |
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Thanks, Cameron! It looks like there is a merge conflict in |
Summary
fixes #11809
Details and comments