Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Qiskit 1.2.3 #13256

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

jakelishman
Copy link
Member

Summary

Details and comments

This is waiting for #13255 as the final PR in the 1.2.3 series.

@jakelishman jakelishman added the Changelog: None Do not include in changelog label Oct 2, 2024
@jakelishman jakelishman added this to the 1.2.3 milestone Oct 2, 2024
@jakelishman jakelishman requested a review from a team as a code owner October 2, 2024 13:41
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

@@ -0,0 +1,6 @@
---
prelude: >
Qiskit 1.2.3 is a patch release fixing a problem in QPY that could cause files generated by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Qiskit 1.2.3 is a patch release fixing a problem in QPY that could cause files generated by
Qiskit v1.2.3 is a patch release fixing a problem in QPY that could cause files generated by

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah this is new guidance we got with version numbers. It'd be helpful to use this in other places you have a version string.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the other PR: I'll leave this as-is for this release, since if this is a general editorial style we want to switch to, we'll need to do the entire 1.2 series of release notes in one go (and probably all the other series of release notes too) to avoid intra-page fragmentation of style.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelishman jakelishman merged commit e198fd0 into Qiskit:stable/1.2 Oct 2, 2024
14 checks passed
@jakelishman jakelishman deleted the prepare-1.2.3 branch October 2, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants