fix BasicAer sampling bug #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajavadia
requested review from
1ucian0,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
mtreinish,
nonhermitian and
taalexander
as code owners
jaygambetta
approved these changes
Dec 29, 2018
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Feb 25, 2019
* fix BasicAer sampling bug
* changelog
* remove legacysimulator from test_compile
Conflicts:
CHANGELOG.rst
test/python/tools/test_compiler.py
The changelog conflicts were inevitable as the stable branch doesn't
have the same history as master. As for the test conflict it was a
difference in the simulator (python vs c++) used, this backport
switches to use the python like on master.
(cherry picked from commit 5f7b2e7)
mtreinish
added a commit
that referenced
this pull request
Mar 4, 2019
* fix BasicAer sampling bug (#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too
ajavadia
pushed a commit
that referenced
this pull request
Mar 10, 2019
* fix BasicAer sampling bug (#1624) (#1859) * fix BasicAer sampling bug (#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too * Bump version and prepare for 0.7.1 release (#1886) * Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo * Reverted changes from merge with Stable * Fixed changelog
ajavadia
pushed a commit
that referenced
this pull request
May 9, 2019
* fix BasicAer sampling bug (#1624) (#1859) * fix BasicAer sampling bug (#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too * Bump version and prepare for 0.7.1 release (#1886) * Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix instruction inheritance issues (#1900) * Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo * Revert "Fix instruction inheritance issues (#1900)" (#1906) This reverts commit 36d5d5d. * Relax schema validation on backendconfiguration (#2258) * Relax schema validation on backendconfiguration The schema validation for backendconfig was set too tightly and it was rejecting valid responses from the backend API. This potentially causes issues when running against the api. This commit addresses this by changing the schema validation to ensure that we properly validate the response received by the backends and no longer reject valid responses moving forward. * Add changelog * Fix tests and lint * Bump version and prepare for 0.7.2 release (#2269) To prepare for the 0.7.2 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix typo in changelog (#2270) This finishes a last minute typo in the changelog to link to the correct version. * Install twine in wheel build jobs (#2290) The wheel build jobs failed to install twine so when the jobs completed and went to upload the wheels this failed because the command wasn't found. This commit fixes the issue by installing twine as part of the wheel build job set ups so that we can actually upload our built binaries. * fix * check at the end * undo order flip * syntax * DeprecationWarning message (#2350) * clean up stable
ajavadia
pushed a commit
that referenced
this pull request
May 9, 2019
* fix BasicAer sampling bug (#1624) (#1859) * fix BasicAer sampling bug (#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too * Bump version and prepare for 0.7.1 release (#1886) * Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix instruction inheritance issues (#1900) * Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo * Revert "Fix instruction inheritance issues (#1900)" (#1906) This reverts commit 36d5d5d. * Relax schema validation on backendconfiguration (#2258) * Relax schema validation on backendconfiguration The schema validation for backendconfig was set too tightly and it was rejecting valid responses from the backend API. This potentially causes issues when running against the api. This commit addresses this by changing the schema validation to ensure that we properly validate the response received by the backends and no longer reject valid responses moving forward. * Add changelog * Fix tests and lint * Bump version and prepare for 0.7.2 release (#2269) To prepare for the 0.7.2 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix typo in changelog (#2270) This finishes a last minute typo in the changelog to link to the correct version. * Install twine in wheel build jobs (#2290) The wheel build jobs failed to install twine so when the jobs completed and went to upload the wheels this failed because the command wasn't found. This commit fixes the issue by installing twine as part of the wheel build job set ups so that we can actually upload our built binaries. * level 2 and 3 honors seed_transpiler * clean * clean up!
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* fix BasicAer sampling bug (Qiskit#1624) (Qiskit#1859) * fix BasicAer sampling bug (Qiskit#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too * Bump version and prepare for 0.7.1 release (Qiskit#1886) * Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo * Reverted changes from merge with Stable * Fixed changelog
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
…2357) * fix BasicAer sampling bug (Qiskit#1624) (Qiskit#1859) * fix BasicAer sampling bug (Qiskit#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too * Bump version and prepare for 0.7.1 release (Qiskit#1886) * Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix instruction inheritance issues (Qiskit#1900) * Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo * Revert "Fix instruction inheritance issues (Qiskit#1900)" (Qiskit#1906) This reverts commit 36d5d5d. * Relax schema validation on backendconfiguration (Qiskit#2258) * Relax schema validation on backendconfiguration The schema validation for backendconfig was set too tightly and it was rejecting valid responses from the backend API. This potentially causes issues when running against the api. This commit addresses this by changing the schema validation to ensure that we properly validate the response received by the backends and no longer reject valid responses moving forward. * Add changelog * Fix tests and lint * Bump version and prepare for 0.7.2 release (Qiskit#2269) To prepare for the 0.7.2 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix typo in changelog (Qiskit#2270) This finishes a last minute typo in the changelog to link to the correct version. * Install twine in wheel build jobs (Qiskit#2290) The wheel build jobs failed to install twine so when the jobs completed and went to upload the wheels this failed because the command wasn't found. This commit fixes the issue by installing twine as part of the wheel build job set ups so that we can actually upload our built binaries. * fix * check at the end * undo order flip * syntax * DeprecationWarning message (Qiskit#2350) * clean up stable
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* fix BasicAer sampling bug (Qiskit#1624) (Qiskit#1859) * fix BasicAer sampling bug (Qiskit#1624) * fix BasicAer sampling bug * changelog * remove legacysimulator from test_compile Conflicts: CHANGELOG.rst test/python/tools/test_compiler.py The changelog conflicts were inevitable as the stable branch doesn't have the same history as master. As for the test conflict it was a difference in the simulator (python vs c++) used, this backport switches to use the python like on master. (cherry picked from commit 5f7b2e7) * Try pinning isort version * Use constraints from last working version of lint * Add requirements constraints too * Bump version and prepare for 0.7.1 release (Qiskit#1886) * Bump version and prepare for 0.7.1 release To prepare for the 0.7.1 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix instruction inheritance issues (Qiskit#1900) * Addressed issue with instruction.py which prohibited inheritance of QuantumRegisters and ClassicalRegisters * Updated changelog * Fixed typo * Revert "Fix instruction inheritance issues (Qiskit#1900)" (Qiskit#1906) This reverts commit 36d5d5d. * Relax schema validation on backendconfiguration (Qiskit#2258) * Relax schema validation on backendconfiguration The schema validation for backendconfig was set too tightly and it was rejecting valid responses from the backend API. This potentially causes issues when running against the api. This commit addresses this by changing the schema validation to ensure that we properly validate the response received by the backends and no longer reject valid responses moving forward. * Add changelog * Fix tests and lint * Bump version and prepare for 0.7.2 release (Qiskit#2269) To prepare for the 0.7.2 bugfix release we need to increase the version number and update the changelog. This commit takes care of that so we can tag the release and build it. * Fix typo in changelog (Qiskit#2270) This finishes a last minute typo in the changelog to link to the correct version. * Install twine in wheel build jobs (Qiskit#2290) The wheel build jobs failed to install twine so when the jobs completed and went to upload the wheels this failed because the command wasn't found. This commit fixes the issue by installing twine as part of the wheel build job set ups so that we can actually upload our built binaries. * level 2 and 3 honors seed_transpiler * clean * clean up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1583
A bug in the BasicAer qasm_simulator caused measurement sampling to behave incorrectly when more qubits existed than being measured.
This fix also allows us to use BasicAer in the one remaining test in
test_compiler. So now the only tests using the legacy_simulator are the ones living intest/python/old_aer_integration_test. So we just need to move those out of Terra and then #1621 can be closed.