Defaults in TranspileConfig (now called PassManagerConfig) #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
requested review from
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
lcapelluto,
mtreinish,
nonhermitian and
taalexander
as code owners
ajavadia
reviewed
Sep 4, 2019
added 10 commits
September 5, 2019 09:05
1ucian0
changed the title
added 2 commits
September 8, 2019 18:45
added 4 commits
January 13, 2020 17:05
ajavadia
reviewed
Jan 23, 2020
added 8 commits
January 24, 2020 15:26
…terra into defaults_TranspileConfig
ajavadia
approved these changes
Feb 5, 2020
|
I agree with @ajavadia lets make this an early merge for the 0.13.0 cycle. I'm updating the milestone accordingly. |
|
Removing |
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* TranspileConfig defaults * defatuls for TranspileConfig * explicit kwargs * remove __getattr__ None * move cm checks to _parse_coupling_map * transpile_config as a dict * pass manager config * circuit is yet another transpiler param * TranspileConfigSchema -> PassManagerConfigSchema * removing unsed parameters in PassManagerConfig * no need for _transpile_circuit anymore * pass manager callback at construction time * docstring * changelog * deprecate callback from construction time * _parse_output_name creates Nones instead of circuit.name * transpile_config -> transpile_args * CouplingMap(backend.configuration().coupling_map) * reformat * fixing test/python/transpiler/test_passmanager_run.py * run(..., output_name=None, callback=None) * basis * kwargs * transpile_args[pass_manager_config].basis_gates * callback at run time * lint * release note * docstring * other -> upgrade * release note * style * fix * line too long * reverse the changes in about parallel * rollback transpile_circuit * lint * release note * expanding the parameters * remove optimization level * remove pass_manager_config as a transpile_circuit arg * output_name and callback are optional * Update qiskit/compiler/transpile.py Co-Authored-By: Ali Javadi-Abhari <ajavadia@users.noreply.github.com> * documentation * parse callback * remove circuit from transpile_args * Update qiskit/transpiler/transpile_circuit.py Co-Authored-By: Ali Javadi-Abhari <ajavadia@users.noreply.github.com> * rename transpile_args_circuits to list_transpile_args.append * new path for passes * back to old _parse_coupling_map * undoing _parse_output_name * comments on the transpiler configuration * docstring * remove transpile_circuit Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Kevin Krsulich <kevin@krsulich.net> Co-authored-by: Ali Javadi-Abhari <ajavadia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While write the release notes for #3004, I realized editing a preset passmanager is a real use-case. That requires a more user-friendly
TranspileConfig. For example, it needs good defaults.If I understand correctly this use-case, a user should be able to instantiate a preset pass manager doing something like this:
If the
level_0_pass_managerparameter is not optional, thenTranspileConfig()should be a thing. This PR allows it.