redress global_phase in controlled UnitaryGate #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the matrix for UnitaryGate internally used ctrl_state when generating the matrix. However, when getting classes definition method, X gates would be composed with the circuit undoing the controls. This change makes the internally stored matrix be the one with closed controls.
Cryoris
added
the
Changelog: Bugfix
|
LGTM 👍 This fixes a bug when the control state wasn't |
Added reno which mentions this. |
Cryoris
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to a PR #4565 to simplify handling of global_phase in controlled UnitaryGate similar to the rest of the PR.
Details and comments