Test circuit drawer uses "π" instead of "pi" #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejomonbar
requested review from
maddy-tod,
nonhermitian and
a team
as code owners
|
@1ucian0 We'd discussed also doing the dagger for sdg, tdg, and sxdg for the text drawer. Something like |
1ucian0
changed the title
1ucian0
added
the
Changelog: New Feature
|
I dont think there is |
1ucian0
approved these changes
Oct 14, 2020
Thank you for helping me. Looking forward to continuing helping |
|
I dont think there is |
mtreinish
removed
the
Changelog: New Feature
mtreinish
added a commit
to mtreinish/aqua
that referenced
this pull request
Mar 16, 2021
This commit fixes the usage of internal only explicitly private attributes of basicaer's job class. These look they were used to manually create a job id which was manually set ahead of time despite still being a random uuid and then launching a simulation from that constructed job object. Which is both the incorrect order to run a simulation (runs generate jobs, not the other way around) but also served no functional purpose. This commit removes this as this is a blocker for Qiskit/qiskit#5218 which is upgrading the basic aer provider to use the latest versioned provider interface which removes all of those private methods and also moves to a synchronous execution model.
manoelmarques
pushed a commit
to qiskit-community/qiskit-aqua
that referenced
this pull request
Mar 18, 2021
* Stop using basic aer internal private attributes This commit fixes the usage of internal only explicitly private attributes of basicaer's job class. These look they were used to manually create a job id which was manually set ahead of time despite still being a random uuid and then launching a simulation from that constructed job object. Which is both the incorrect order to run a simulation (runs generate jobs, not the other way around) but also served no functional purpose. This commit removes this as this is a blocker for Qiskit/qiskit#5218 which is upgrading the basic aer provider to use the latest versioned provider interface which removes all of those private methods and also moves to a synchronous execution model. * Fix lint * Update run_circuits.py Fix copyright Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
kdk
added
the
Changelog: New Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #4959
Details and comments
Change pi_check function when output is "text" from "pi" to "π". Also, the test cases were updated to check different circuits with the new symbol "π". Different encoders were tested to see if they accepted "π" and gave good results.