make commutative_cancellation basis aware #5672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdk
added
the
stable backport potential
kdk
reviewed
Feb 18, 2021
qiskit/transpiler/passes/optimization/commutative_cancellation.py
Outdated
Show resolved
Hide resolved
qiskit/transpiler/passes/optimization/commutative_cancellation.py
Outdated
Show resolved
Hide resolved
qiskit/transpiler/passes/optimization/commutative_cancellation.py
Outdated
Show resolved
Hide resolved
qiskit/transpiler/passes/optimization/commutative_cancellation.py
Outdated
Show resolved
Hide resolved
qiskit/transpiler/passes/optimization/commutative_cancellation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
kdk
reviewed
Feb 19, 2021
Co-authored-by: Kevin Krsulich <kevin@krsulich.net>
kdk
previously approved these changes
Mar 2, 2021
kdk
approved these changes
Mar 3, 2021
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
* fixes #5644 * move change to commutation analysis to new pr. * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * check global phase * minor fix * preserve global phase in commutative_cancellation * Update test/python/transpiler/test_commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * add blank line * add release note Co-authored-by: Kevin Krsulich <kevin@krsulich.net> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com> (cherry picked from commit 0d85759) # Conflicts: # qiskit/transpiler/passes/optimization/commutative_cancellation.py # qiskit/transpiler/preset_passmanagers/level2.py
mergify bot
added a commit
that referenced
this pull request
Mar 4, 2021
* make commutative_cancellation basis aware (#5672) * fixes #5644 * move change to commutation analysis to new pr. * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * Update qiskit/transpiler/passes/optimization/commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * check global phase * minor fix * preserve global phase in commutative_cancellation * Update test/python/transpiler/test_commutative_cancellation.py Co-authored-by: Kevin Krsulich <kevin@krsulich.net> * add blank line * add release note Co-authored-by: Kevin Krsulich <kevin@krsulich.net> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com> (cherry picked from commit 0d85759) # Conflicts: # qiskit/transpiler/passes/optimization/commutative_cancellation.py # qiskit/transpiler/preset_passmanagers/level2.py * Fix merge conflicts * Fix typo Co-authored-by: ewinston <ewinston@us.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes optionally possible to tell the
commutative_cancellationpass about the target basis. Currently the pass automatically replaces gates which commute withZwithU1. This change makes it possible to optionally specify a target basis.This pr also updates the pass to preserve global phase.
Details and comments
Functionally the target basis will be the union of the gates in the circuit with the target basis, prioritizing gates in the circuit. If the effective basis does not include a variable z_rotation gate no commutative cancellation will occur, therefore one should now be explicit about target basis when using this pass.