Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the class RZXCalibrationBuilderNoEcho #6300

Merged
merged 15 commits into from
May 22, 2021

Conversation

catornow
Copy link
Contributor

Summary

In this PR I added a new class called RZXCalibrationBuilderNoEcho.

Details and comments

The RZXCalibrationBuilderNoEcho is a variation of the RZXCalibrationBuilder as it creates calibrations for the cross-resonance pulses without inserting the echo pulses in the pulse schedule. This enables exposing the echo in the cross-resonance sequence as gates so that the transpiler can simplify them.
The RZXCalibrationBuilderNoEcho only supports the hardware-native direction of the CX gate.

@catornow catornow requested a review from a team as a code owner April 26, 2021 14:19
Copy link
Contributor

@eggerdj eggerdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Some minor suggestions.

eggerdj
eggerdj previously approved these changes Apr 30, 2021
Copy link
Contributor

@eggerdj eggerdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lcapelluto lcapelluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests:)

Copy link
Contributor

@eggerdj eggerdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. Here are some comments to improve this.

test/python/pulse/test_calibrationbuilder.py Outdated Show resolved Hide resolved
test/python/pulse/test_calibrationbuilder.py Outdated Show resolved Hide resolved
catornow and others added 4 commits May 6, 2021 21:29
Implemented Daniel's suggestions

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>
Copy link
Contributor

@eggerdj eggerdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lcapelluto lcapelluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@eggerdj eggerdj merged commit 839d294 into Qiskit:main May 22, 2021
@mtreinish mtreinish added the Changelog: New Feature Include in the "Added" section of the changelog label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants