Update options to be a mapping instead of a simple namespace #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
added
on hold
This commit changes the options class to be a mapping instead of a simple namespace. While we wanted to preserve attribute based access primarily the simple namespace is too limited in practice and involves a lot of hacking around the internals such as frequent calls to Options.__dict__ to get an iterator of fields in the options. To improve the usability of the class without breaking existing users this changes the base class to be a MutableMapping and adds the necessary methods to make it usable like a dict or a simple namespace.
mtreinish
changed the title
|
Ugh, it looks like this is breaking Aer in some way and because of how the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit changes the options class to be a mapping instead of a
simple namespace. While we wanted to preserve attribute based access
primarily the simple namespace is too limited in practice and involves a
lot of hacking around the internals such as frequent calls to
Options.__dict__to get an iterator of fields in the options. To improvethe usability of the class without breaking existing users this changes
the base class to be a
MutableMappingand adds the necessary methods tomake it usable like a dict or a simple namespace.
Details and comments